Use an array instead of a string for the FQDN parameter #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBigLee
force-pushed
the
nextcloud/multi_fqdn
branch
from
3622955
to
94346c7
Compare
3 tasks
We want to allow setting multiple FQDNs for the nextcloud service, so that the end user can specify multiple endpoints. Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
nextcloud/multi_fqdn
branch
from
94346c7
to
b6f544b
Compare
Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
requested review from
a team,
Kidswiss,
wejdross and
zugao
and removed request for
a team
|
In order for this feature to work, we need to update to the latest helm chart version. See: vshn/component-appcat#547 |
wejdross
requested changes
Nov 26, 2024
Signed-off-by: Nicolas Bigler <[email protected]>
wejdross
approved these changes
Nov 26, 2024
|
please fix Summary section before merging |
Kidswiss
approved these changes
Nov 26, 2024
TheBigLee
force-pushed
the
nextcloud/multi_fqdn
branch
from
b47d71f
to
6cf097f
Compare
TheBigLee
force-pushed
the
nextcloud/multi_fqdn
branch
from
6cf097f
to
875658a
Compare
Kidswiss
requested changes
Nov 26, 2024
wejdross
approved these changes
Nov 26, 2024
TheBigLee
force-pushed
the
nextcloud/multi_fqdn
branch
from
875658a
to
d5844b3
Compare
zugao
reviewed
Nov 26, 2024
zugao
reviewed
Nov 26, 2024
TheBigLee
force-pushed
the
nextcloud/multi_fqdn
branch
from
d5844b3
to
659e621
Compare
Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
nextcloud/multi_fqdn
branch
from
659e621
to
4990d7c
Compare
Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
nextcloud/multi_fqdn
branch
from
404ff7c
to
3ac924e
Compare
Kidswiss
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog